Small fixes from PR

Added peer dependency, scripts to package.json, and added error logs, removed webServiceURL and auth token
This commit is contained in:
Saim Khan
2023-07-18 17:54:13 +01:00
committed by GitHub
parent 70859ae5a2
commit 93932d4159
2 changed files with 16 additions and 12 deletions

View File

@@ -26,8 +26,6 @@ exports.pass = functions.https.onRequest((request, response) => {
}, },
}, },
{ {
authenticationToken: "AUTH_TOKEN",
webServiceURL: "https://us-central1-YOUR-FUNCTION.cloudfunctions.net/FUNCTION_NAME",
serialNumber: request.body.serialNumber, serialNumber: request.body.serialNumber,
description: "DESCRIPTION", description: "DESCRIPTION",
logoText: request.body.logoText, logoText: request.body.logoText,
@@ -119,13 +117,13 @@ exports.pass = functions.https.onRequest((request, response) => {
try { try {
await storageRef.file(`thumbnails/${thumbnailFile}`).download({destination: tempPath1}) await storageRef.file(`thumbnails/${thumbnailFile}`).download({destination: tempPath1})
} catch (error) { } catch (error) {
// console.error(error)
} }
let buffer = Buffer.alloc(0); let buffer = Buffer.alloc(0);
try { try {
buffer = fs.readFileSync(tempPath1) buffer = fs.readFileSync(tempPath1)
} catch (error) { } catch (error) {
// console.error(error)
} }
newPass.addBuffer("thumbnail.png", buffer) newPass.addBuffer("thumbnail.png", buffer)
newPass.addBuffer("thumbnail@2x.png", buffer) newPass.addBuffer("thumbnail@2x.png", buffer)
@@ -136,13 +134,13 @@ exports.pass = functions.https.onRequest((request, response) => {
try { try {
await storageRef.file(`logos/${logoFile}`).download({destination: tempPath2}) await storageRef.file(`logos/${logoFile}`).download({destination: tempPath2})
} catch (error) { } catch (error) {
// console.error(error)
} }
let buffer = Buffer.alloc(0); let buffer = Buffer.alloc(0);
try { try {
buffer = fs.readFileSync(tempPath2) buffer = fs.readFileSync(tempPath2)
} catch (error) { } catch (error) {
// console.error(error)
} }
newPass.addBuffer("logo.png", buffer) newPass.addBuffer("logo.png", buffer)
newPass.addBuffer("logo@2x.png", buffer) newPass.addBuffer("logo@2x.png", buffer)
@@ -157,15 +155,15 @@ exports.pass = functions.https.onRequest((request, response) => {
// Delete thumbnail file in Firebase Storage // Delete thumbnail file in Firebase Storage
storageRef.file(`thumbnails/${thumbnailFile}`).delete().then(() => { storageRef.file(`thumbnails/${thumbnailFile}`).delete().then(() => {
console.log('Thumbnail file deleted successfully'); console.log('Thumbnail file deleted successfully');
}).catch((err) => { }).catch((error) => {
console.error(err); console.error(error);
}) })
// Delete logo file in Firebase Storage // Delete logo file in Firebase Storage
storageRef.file(`logos/${logoFile}`).delete().then(() => { storageRef.file(`logos/${logoFile}`).delete().then(() => {
console.log('Logo file deleted successfully'); console.log('Logo file deleted successfully');
}).catch((err) => { }).catch((error) => {
console.error(err); console.error(error);
}) })
} catch (error) { } catch (error) {

View File

@@ -6,7 +6,11 @@
"shell": "firebase functions:shell", "shell": "firebase functions:shell",
"start": "npm run shell", "start": "npm run shell",
"deploy": "firebase deploy --only functions", "deploy": "firebase deploy --only functions",
"logs": "firebase functions:log" "logs": "firebase functions:log",
"service:link-pg": "cd ../.. && npm run build && npm link",
"preinstall": "npm run clear:deps",
"postinstall": "npm run service:link-pg && npm link passkit-generator",
"clear:deps": "rm -rf node_modules"
}, },
"engines": { "engines": {
"node": "16" "node": "16"
@@ -18,9 +22,11 @@
"firebase-admin": "^10.0.2", "firebase-admin": "^10.0.2",
"firebase-functions": "^3.18.0", "firebase-functions": "^3.18.0",
"os": "^0.1.2", "os": "^0.1.2",
"passkit-generator": "^3.1.7",
"path": "^0.12.7" "path": "^0.12.7"
}, },
"peerDependencies": {
"passkit-generator": "latest"
},
"devDependencies": { "devDependencies": {
"firebase-functions-test": "^0.2.0" "firebase-functions-test": "^0.2.0"
}, },