From 93932d4159eee8240ab7603874e1535595b664ea Mon Sep 17 00:00:00 2001
From: Saim Khan <70058899+Saim-Khan1@users.noreply.github.com>
Date: Tue, 18 Jul 2023 17:54:13 +0100
Subject: [PATCH] Small fixes from PR

Added peer dependency, scripts to package.json, and added error logs, removed webServiceURL and auth token
---
 examples/firebase/index.js     | 18 ++++++++----------
 examples/firebase/package.json | 10 ++++++++--
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/examples/firebase/index.js b/examples/firebase/index.js
index 1536c85..ba90999 100644
--- a/examples/firebase/index.js
+++ b/examples/firebase/index.js
@@ -26,8 +26,6 @@ exports.pass = functions.https.onRequest((request, response) => {
         }, 
     },
         {
-            authenticationToken: "AUTH_TOKEN",
-            webServiceURL: "https://us-central1-YOUR-FUNCTION.cloudfunctions.net/FUNCTION_NAME",
             serialNumber: request.body.serialNumber,
             description: "DESCRIPTION",
             logoText: request.body.logoText,
@@ -119,13 +117,13 @@ exports.pass = functions.https.onRequest((request, response) => {
                 try {
                     await storageRef.file(`thumbnails/${thumbnailFile}`).download({destination: tempPath1})
                 } catch (error) {
-                    //
+                    console.error(error)
                 }
                 let buffer = Buffer.alloc(0);
                 try {
                     buffer = fs.readFileSync(tempPath1)
                 } catch (error) {
-                    //
+                    console.error(error)
                 }
                 newPass.addBuffer("thumbnail.png", buffer)
                 newPass.addBuffer("thumbnail@2x.png", buffer)
@@ -136,13 +134,13 @@ exports.pass = functions.https.onRequest((request, response) => {
             try {
                 await storageRef.file(`logos/${logoFile}`).download({destination: tempPath2})
             } catch (error) {
-                //
+                console.error(error)
             }
             let buffer = Buffer.alloc(0);
             try {
                 buffer = fs.readFileSync(tempPath2)
             } catch (error) {
-                //
+                console.error(error)
             }
             newPass.addBuffer("logo.png", buffer)
             newPass.addBuffer("logo@2x.png", buffer)
@@ -157,15 +155,15 @@ exports.pass = functions.https.onRequest((request, response) => {
                 // Delete thumbnail file in Firebase Storage
                 storageRef.file(`thumbnails/${thumbnailFile}`).delete().then(() => {
                     console.log('Thumbnail file deleted successfully');
-                }).catch((err) => {
-                    console.error(err);
+                }).catch((error) => {
+                    console.error(error);
                 })
 
                 // Delete logo file in Firebase Storage
                 storageRef.file(`logos/${logoFile}`).delete().then(() => {
                     console.log('Logo file deleted successfully');
-                }).catch((err) => {
-                    console.error(err);
+                }).catch((error) => {
+                    console.error(error);
                 })
 
             } catch (error) {
diff --git a/examples/firebase/package.json b/examples/firebase/package.json
index 60e73e8..0e887fb 100644
--- a/examples/firebase/package.json
+++ b/examples/firebase/package.json
@@ -6,7 +6,11 @@
     "shell": "firebase functions:shell",
     "start": "npm run shell",
     "deploy": "firebase deploy --only functions",
-    "logs": "firebase functions:log"
+    "logs": "firebase functions:log",
+    "service:link-pg": "cd ../.. && npm run build && npm link",
+    "preinstall": "npm run clear:deps",
+    "postinstall": "npm run service:link-pg && npm link passkit-generator",
+    "clear:deps": "rm -rf node_modules"
   },
   "engines": {
     "node": "16"
@@ -18,9 +22,11 @@
     "firebase-admin": "^10.0.2",
     "firebase-functions": "^3.18.0",
     "os": "^0.1.2",
-    "passkit-generator": "^3.1.7",
     "path": "^0.12.7"
   },
+  "peerDependencies": {
+		"passkit-generator": "latest"
+	},
   "devDependencies": {
     "firebase-functions-test": "^0.2.0"
   },