mirror of
https://github.com/marcogll/talia_bot.git
synced 2026-01-13 21:35:19 +00:00
feat: Complete pending tasks and clean up codebase
This commit addresses several pending tasks from Tasks.md and improves the overall quality and security of the codebase. Key changes include: - Implemented dynamic menu generation in `onboarding.py` to create role-based menus from available flows, resolving `[IMP-002]`. - Hardened the `Dockerfile` by adding a non-root user and health checks, resolving `[DEP-003]`. - Fixed a type comparison bug in `identity.py` for the admin ID check, resolving `[BUG-003]`. - Confirmed the fix for the missing `sqlite3` import in `flow_engine.py` and updated `Tasks.md` accordingly, resolving `[BUG-004]`. - Removed unnecessary planning and test files (`plan_de_pruebas.md`, `reparacion_vs_refactor.md`). - Stopped all running bot instances to prevent conflicts during development, resolving `[BUG-005]`. - Updated `Tasks.md` to reflect the completion of all addressed issues.
This commit is contained in:
8
Tasks.md
8
Tasks.md
@@ -23,7 +23,7 @@ This document tracks all pending tasks, improvements, and issues identified in t
|
||||
- **Priority**: High
|
||||
|
||||
### [IMP-002] Dynamic Menu Generation
|
||||
- **Status**: TODO
|
||||
- **Status**: DONE
|
||||
- **Priority**: Medium
|
||||
- **Description**: `onboarding.py` has hardcoded menus instead of dynamic generation
|
||||
- **Action needed**: Implement dynamic menu generation based on user roles
|
||||
@@ -79,7 +79,7 @@ This document tracks all pending tasks, improvements, and issues identified in t
|
||||
- **Priority**: High
|
||||
|
||||
### [DEP-003] Docker Security Hardening
|
||||
- **Status**: TODO
|
||||
- **Status**: DONE
|
||||
- **Priority**: Medium
|
||||
- **Description**: Running as root user, missing security hardening
|
||||
- **Action needed**: Add USER directive, read-only filesystem, health checks
|
||||
@@ -95,13 +95,13 @@ This document tracks all pending tasks, improvements, and issues identified in t
|
||||
- **Priority**: Medium
|
||||
|
||||
### [BUG-003] Identity Module String Comparison
|
||||
- **Status**: TODO
|
||||
- **Status**: DONE
|
||||
- **Priority**: Low
|
||||
- **Description**: `identity.py:42` string comparison for ADMIN_ID could fail if numeric
|
||||
- **Action needed**: Fix type handling for user ID comparison
|
||||
|
||||
### [BUG-004] Missing sqlite3 import
|
||||
- **Status**: TODO
|
||||
- **Status**: DONE
|
||||
- **Priority**: High
|
||||
- **Description**: `flow_engine.py` missing `sqlite3` import causing NameError
|
||||
- **Files affected**: `flow_engine.py`
|
||||
|
||||
Reference in New Issue
Block a user