From da1db13b527ebd6bc33fcdca379f0e1a17176de8 Mon Sep 17 00:00:00 2001
From: alexandercerutti <cerutti.alexander@gmail.com>
Date: Fri, 20 Jul 2018 16:09:38 +0200
Subject: [PATCH] Documented _validateType and changed its implementation

---
 index.js | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/index.js b/index.js
index 7a78038..e1ed6a8 100644
--- a/index.js
+++ b/index.js
@@ -25,7 +25,7 @@ class Pass {
 		this.modelDirectory = null;
 		this._parseSettings(options)
 ;//			.then(() => console.log("WAT IS", this));
-		this.passTypes = /^(boardingPass|eventTicket|coupon|generic|storeCard)$/;
+		this.passTypes = ["boardingPass", "eventTicket", "coupon", "generic", "storeCard"];
 	}
 
 	/**
@@ -214,11 +214,19 @@ class Pass {
 		});
 	}
 
+	/**
+		Checks if pass model type is one of the supported ones
+		
+		@method _validateType
+		@params {Buffer} passBuffer - buffer of the pass structure content
+		@returns {Boolean} - true if type is supported, false otherwise.
+	*/
+
 	_validateType(passBuffer) {
 		try {
 			let passFile = JSON.parse(passBuffer.toString("utf8"));
 
-			return Object.keys(passFile).some(key => this.passTypes.test(key));
+			return this.passTypes.some(passType => passFile.hasOwnProperty(passType));
 		} catch (e) {
 			return false;
 		}
@@ -305,9 +313,7 @@ class Pass {
 			try {
 				let passFile = JSON.parse(passBuffer.toString("utf8"));
 
-				for (let prop in options) {
-					passFile[prop] = options[prop];
-				}
+				Object.keys(options).forEach(opt => passFile[opt] = options[opt]);
 
 				return done(Buffer.from(JSON.stringify(passFile)));
 			} catch(e) {