From 724c2af7e5e51c73b598261bbdeef5049e9a6b75 Mon Sep 17 00:00:00 2001
From: Alexander Cerutti <cerutti.alexander@gmail.com>
Date: Sun, 30 Jul 2023 01:55:15 +0200
Subject: [PATCH] Improved storage reading

---
 examples/firebase/functions/src/index.ts | 31 ++++++++----------------
 1 file changed, 10 insertions(+), 21 deletions(-)

diff --git a/examples/firebase/functions/src/index.ts b/examples/firebase/functions/src/index.ts
index e5e0d81..c176bf0 100644
--- a/examples/firebase/functions/src/index.ts
+++ b/examples/firebase/functions/src/index.ts
@@ -242,20 +242,14 @@ export const pass = functions.https.onRequest(
 						await storageRef
 							.file(`thumbnails/${thumbnailFile}`)
 							.download({ destination: tempPath1 });
+
+						const buffer = fs.readFileSync(tempPath1);
+
+						newPass.addBuffer("thumbnail.png", buffer);
+						newPass.addBuffer("thumbnail@2x.png", buffer);
 					} catch (error) {
 						console.error(error);
 					}
-
-					let buffer = Buffer.alloc(0);
-
-					try {
-						buffer = fs.readFileSync(tempPath1);
-					} catch (error) {
-						console.error(error);
-					}
-
-					newPass.addBuffer("thumbnail.png", buffer);
-					newPass.addBuffer("thumbnail@2x.png", buffer);
 				}
 			}
 
@@ -266,19 +260,14 @@ export const pass = functions.https.onRequest(
 					await storageRef
 						.file(`logos/${logoFile}`)
 						.download({ destination: tempPath2 });
+
+					const buffer = fs.readFileSync(tempPath2);
+
+					newPass.addBuffer("logo.png", buffer);
+					newPass.addBuffer("logo@2x.png", buffer);
 				} catch (error) {
 					console.error(error);
 				}
-
-				let buffer = Buffer.alloc(0);
-				try {
-					buffer = fs.readFileSync(tempPath2);
-				} catch (error) {
-					console.error(error);
-				}
-
-				newPass.addBuffer("logo.png", buffer);
-				newPass.addBuffer("logo@2x.png", buffer);
 			}
 
 			const bufferData = newPass.getAsBuffer();