marcogll/passkit-generator
1
0
Fork 0
mirror of https://github.com/marcogll/passkit-generator.git synced 2026-03-15 21:25:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Changed .localize method to need mandatory translations to be passed as second parameter

Browse Source
This commit is contained in:
Alexander Cerutti
2021-10-18 00:43:53 +02:00
parent be8d524ad3
commit 547045076a
3 changed files with 47 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
spec/PKPass.ts
View File

@@ -584,39 +584,60 @@ describe("PKPass", () => {
describe("localize", () => {
it("should fail throw if lang is not a string", () => {
// @ts-expect-error
expect(() => pass.localize(null)).toThrowError(
TypeError,
Messages.LANGUAGES.INVALID_TYPE.replace("%s", "object"),
Messages.LANGUAGES.INVALID_LANG.replace("%s", "object"),
);
// @ts-expect-error
expect(() => pass.localize(undefined)).toThrowError(
TypeError,
Messages.LANGUAGES.INVALID_TYPE.replace("%s", "undefined"),
Messages.LANGUAGES.INVALID_LANG.replace("%s", "undefined"),
);
// @ts-expect-error
expect(() => pass.localize(5)).toThrowError(
TypeError,
Messages.LANGUAGES.INVALID_TYPE.replace("%s", "number"),
Messages.LANGUAGES.INVALID_LANG.replace("%s", "number"),
);
// @ts-expect-error
expect(() => pass.localize(true)).toThrowError(
TypeError,
Messages.LANGUAGES.INVALID_TYPE.replace("%s", "boolean"),
Messages.LANGUAGES.INVALID_LANG.replace("%s", "boolean"),
);
// @ts-expect-error
expect(() => pass.localize({})).toThrowError(
TypeError,
Messages.LANGUAGES.INVALID_TYPE.replace("%s", "object"),
Messages.LANGUAGES.INVALID_LANG.replace("%s", "object"),
);
});
it("should create a new language record inside class props", () => {
it("should warn developer if no translations have been passed", () => {
console.warn = jasmine.createSpy("log");
// @ts-expect-error
pass.localize("en");
pass.localize("en", {});
expect(pass[localizationSymbol]["en"]).toEqual({});
expect(console.warn).toHaveBeenCalledWith(
Messages.LANGUAGES.NO_TRANSLATIONS.replace("%s", "en"),
);
expect(console.warn).toHaveBeenCalledTimes(2);
});
it("should create a new language record if some translations are specifies", () => {
pass.localize("en", {
buon_giorno: "Good Morning",
buona_sera: "Good Evening",
});
expect(pass[localizationSymbol]["en"]).toEqual({
buon_giorno: "Good Morning",
buona_sera: "Good Evening",
});
});
it("should accept later translations and merge them with existing ones", () => {
@@ -647,9 +668,13 @@ describe("PKPass", () => {
});
it("should always return undefined", () => {
expect(pass.localize("it", undefined)).toBeUndefined();
expect(pass.localize("it", null)).toBeUndefined();
expect(pass.localize("it", {})).toBeUndefined();
expect(
pass.localize("it", {
say_good_morning: "buongiorno",
say_good_evening: "buonasera",
}),
).toBeUndefined();
});
});